[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)
John Harrison via lldb-commits
lldb-commits at lists.llvm.org
Tue Jan 16 09:56:08 PST 2024
================
@@ -380,12 +380,19 @@ llvm::json::Value DAP::CreateTopLevelScopes() {
return llvm::json::Value(std::move(scopes));
}
-ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame,
- std::string &text) {
+static std::string FirstTerm(llvm::StringRef input) {
+ if (input.empty())
+ return "";
+ const auto terms = llvm::getToken(input, " \t\n\v\f\r.[-(");
----------------
ashgti wrote:
I actually removed the extra characters and left it as whitespace. There are lldb commands like `p/t` or `x/4xw` that can include non alpha numeric characters and users can add aliases, so I think using `ResolveCommand` is the most correct thing to do here.
https://github.com/llvm/llvm-project/pull/78005
More information about the lldb-commits
mailing list