[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

Walter Erquinigo via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 15 14:51:36 PST 2024


================
@@ -380,12 +380,19 @@ llvm::json::Value DAP::CreateTopLevelScopes() {
   return llvm::json::Value(std::move(scopes));
 }
 
-ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame,
-                                               std::string &text) {
+static std::string FirstTerm(llvm::StringRef input) {
+  if (input.empty())
+    return "";
+  const auto terms = llvm::getToken(input, " \t\n\v\f\r.[-(");
----------------
walter-erquinigo wrote:

if the first term is followed by `.[-(`, couldn't we assume that it's code and not a command?

https://github.com/llvm/llvm-project/pull/78005


More information about the lldb-commits mailing list