[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #77949)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

> @JDevlieghere I created a new PR and closed #76683 because I made a mess with a git rebase, and since the other PR had just started I thought it made sense to start anew. I apologize for the confusion. Here I have already addressed most of your comments from 76683.

No worries, thanks for the quick turnaround!

> What is left to do is to add tests with `GdbRemoteTestCaseBase` as you suggested.

👍

> I've kept the support for `DW_OP_WASM_location` in this PR to have it fully working, but I'll be happy to hoist it out in a separate patch with its own dedicated test, if so you prefer.

I'd vote to break it out, it can stand on its own and needs a test anyway. As an added benefit that probably means it gets merged sooner than this larger patch.  

> @xujuntwt95329, from WebAssembly Micro Runtime, has hugely contributed to this work, but I cannot add his name to the reviewers or assignees.

Yeah, I believe you must be a member of the project to be listed there. @xujuntwt95329 if reply or interact with the thread they should become a subscriber and get notifications. Maybe they already do given the mention. Regardless, thank you for your contribution! 

https://github.com/llvm/llvm-project/pull/77949