[Lldb-commits] [lldb] [lldb][ValueObject][NFC] Remove unused parameter to ReadPointedString (PR #77919)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 12 04:50:17 PST 2024


https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/77919

The need for it was removed in `2206b48d6ddabad61979fa69ba09e6b6fb19b0b2`.

>From c1ee450df703a4026923b501e8228c16ff019527 Mon Sep 17 00:00:00 2001
From: Michael Buch <michaelbuch12 at gmail.com>
Date: Fri, 12 Jan 2024 12:32:02 +0000
Subject: [PATCH] [lldb][ValueObject][NFC] Remove unused parameter to
 ReadPointedString

---
 lldb/include/lldb/Core/ValueObject.h | 3 +--
 lldb/source/Core/ValueObject.cpp     | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/lldb/include/lldb/Core/ValueObject.h b/lldb/include/lldb/Core/ValueObject.h
index 3f8005ba696ce8..dec1c7b237ac27 100644
--- a/lldb/include/lldb/Core/ValueObject.h
+++ b/lldb/include/lldb/Core/ValueObject.h
@@ -670,8 +670,7 @@ class ValueObject {
 
   std::pair<size_t, bool>
   ReadPointedString(lldb::WritableDataBufferSP &buffer_sp, Status &error,
-                    uint32_t max_length = 0, bool honor_array = true,
-                    lldb::Format item_format = lldb::eFormatCharArray);
+                    uint32_t max_length = 0, bool honor_array = true);
 
   virtual size_t GetPointeeData(DataExtractor &data, uint32_t item_idx = 0,
                                 uint32_t item_count = 1);
diff --git a/lldb/source/Core/ValueObject.cpp b/lldb/source/Core/ValueObject.cpp
index b2a6d9412ab40b..a5d155d3c6675f 100644
--- a/lldb/source/Core/ValueObject.cpp
+++ b/lldb/source/Core/ValueObject.cpp
@@ -814,7 +814,7 @@ static bool CopyStringDataToBufferSP(const StreamString &source,
 std::pair<size_t, bool>
 ValueObject::ReadPointedString(lldb::WritableDataBufferSP &buffer_sp,
                                Status &error, uint32_t max_length,
-                               bool honor_array, Format item_format) {
+                               bool honor_array) {
   bool was_capped = false;
   StreamString s;
   ExecutionContext exe_ctx(GetExecutionContextRef());



More information about the lldb-commits mailing list