[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

[Greg Clayton via lldb-commits]

================
@@ -1210,15 +1210,16 @@ bool SBValue::GetDescription(SBStream &description) {
 
   ValueLocker locker;
   lldb::ValueObjectSP value_sp(GetSP(locker));
-  if (value_sp) {
-    DumpValueObjectOptions options;
-    options.SetUseDynamicType(m_opaque_sp->GetUseDynamic());
-    options.SetUseSyntheticValue(m_opaque_sp->GetUseSynthetic());
-    value_sp->Dump(strm, options);
-  } else {
+  if (!value_sp) {
     strm.PutCString("No value");
----------------
clayborg wrote:

OMG, that is horrible that we return false and yet still put "No value" into the stream???

https://github.com/llvm/llvm-project/pull/77026