[Lldb-commits] [lldb] [lldb] Add color support to StreamString (PR #77380)

Pete Lawrence via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 9 12:18:53 PST 2024


PortalPete wrote:

> Surprised that no one is using that constructor, and if that's true - is this change to support something else or just making sure we don't make a mistake in future if we do use this class?

Me too!
I'm was working on another patch and figured out this is why I couldn't colorize the text using `StringStream`. As it is today, `StreamString` blocks the ability to enable color with its `Stream` superclass, which was probably just a simple oversight.

The good news is that everything that uses it today (without arguments) won't see any difference, thanks to the default argument to the new parameter, making it opt-in / off by default.

https://github.com/llvm/llvm-project/pull/77380


More information about the lldb-commits mailing list