[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

Walter Erquinigo via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 9 09:18:57 PST 2024


================
@@ -135,6 +135,18 @@ std::vector<std::string> GetStrings(const llvm::json::Object *obj,
   return strs;
 }
 
+static std::string GetDescriptionTrimmed(lldb::SBValue &value) {
+  lldb::SBStream stream;
+  value.GetDescription(stream);
----------------
walter-erquinigo wrote:

The method `bool SBValue::GetDescription(SBStream &description)` returns `true` always. Could you make it return false if the description couldn't be generated, and also abort early in this function in such case?
I've also noticed that `GetDescription` dumps `"No value"` in some cases, which would be better not to display via `lldb-dap`.

https://github.com/llvm/llvm-project/pull/77026


More information about the lldb-commits mailing list