[Lldb-commits] [lldb] [lldb] Fix Intel PT plugin compile errors (PR #77252)

Walter Erquinigo via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 9 08:41:48 PST 2024


walter-erquinigo wrote:

> Also, I noticed some error messages were different for some tests — I'm guessing they may have changed in newer versions of libipt.

That makes sense. In this case I'd just drop text comparisons for those tests. Just knowing that an error was found is good enough.

> FAIL: testStartPerCpuSession (TestTraceStartStopMultipleThreads.TestTraceStartStopMultipleThreads)   

Leave that test failing. I'm pretty that your changes haven't affected this test, so it's been broken for a while. Just ignore it for now :) We can fix it later if that's something that prevents you from doing your actual work.

https://github.com/llvm/llvm-project/pull/77252


More information about the lldb-commits mailing list