[Lldb-commits] [lldb] 09e32ab - [lldb] Deprecate SBBreakpoint::AddName in favor of AddNameWithErrorHandling (#71228)

[via lldb-commits]

Author: Alex Langford
Date: 2024-01-08T13:30:24-08:00
New Revision: 09e32ab75076a1f2270d37343922c86c12bdd047

URL: https://github.com/llvm/llvm-project/commit/09e32ab75076a1f2270d37343922c86c12bdd047
DIFF: https://github.com/llvm/llvm-project/commit/09e32ab75076a1f2270d37343922c86c12bdd047.diff

LOG: [lldb] Deprecate SBBreakpoint::AddName in favor of AddNameWithErrorHandling (#71228)

AddName gives no feedback other than if it succeeded whereas
AddNameWithErrorHandling gives you back an SBError object. I would like
to mark AddName as deprecated and direct folks to use
AddNameWithErorrHandling instead.

---------

Co-authored-by: Med Ismail Bennani <ismail at bennani.ma>

Added: 
    

Modified: 
    lldb/include/lldb/API/SBBreakpoint.h

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/API/SBBreakpoint.h b/lldb/include/lldb/API/SBBreakpoint.h
index 0bb7c31d74f21f..e08df3b6d5ab07 100644
--- a/lldb/include/lldb/API/SBBreakpoint.h
+++ b/lldb/include/lldb/API/SBBreakpoint.h
@@ -112,6 +112,8 @@ class LLDB_API SBBreakpoint {
 
   SBError SetScriptCallbackBody(const char *script_body_text);
 
+  LLDB_DEPRECATED_FIXME("Doesn't provide error handling",
+                        "AddNameWithErrorHandling")
   bool AddName(const char *new_name);
 
   SBError AddNameWithErrorHandling(const char *new_name);