[Lldb-commits] [lldb] [lldb] All ValueObjectSP instances are now valid (non-null) but have an error state (In-progress | Take 2) (PR #77375)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 07d6fbf8d80083470b4371f2ddabd656a9c317e6 c416cad26ed3e84918f639cc5a408682afff451f -- lldb/include/lldb/Breakpoint/Watchpoint.h lldb/include/lldb/Core/ValueObject.h lldb/include/lldb/Core/ValueObjectConstResult.h lldb/include/lldb/Core/ValueObjectConstResultCast.h lldb/include/lldb/Core/ValueObjectConstResultChild.h lldb/include/lldb/Core/ValueObjectConstResultImpl.h lldb/include/lldb/Core/ValueObjectList.h lldb/include/lldb/Core/ValueObjectRegister.h lldb/include/lldb/Core/ValueObjectSyntheticFilter.h lldb/include/lldb/Core/ValueObjectUpdater.h lldb/include/lldb/DataFormatters/TypeSynthetic.h lldb/include/lldb/DataFormatters/ValueObjectPrinter.h lldb/include/lldb/DataFormatters/VectorIterator.h lldb/include/lldb/Expression/ExpressionVariable.h lldb/include/lldb/Expression/UserExpression.h lldb/include/lldb/Interpreter/ScriptInterpreter.h lldb/include/lldb/Target/LanguageRuntime.h lldb/include/lldb/Target/StackFrame.h lldb/include/lldb/Target/StackFrameRecognizer.h lldb/include/lldb/Target/Target.h lldb/include/lldb/Target/Thread.h lldb/include/lldb/Target/ThreadPlan.h lldb/include/lldb/Target/ThreadPlanCallFunction.h lldb/include/lldb/lldb-forward.h lldb/source/Breakpoint/BreakpointLocation.cpp lldb/source/Breakpoint/Watchpoint.cpp lldb/source/Commands/CommandObjectDWIMPrint.cpp lldb/source/Commands/CommandObjectExpression.cpp lldb/source/Commands/CommandObjectFrame.cpp lldb/source/Commands/CommandObjectMemory.cpp lldb/source/Commands/CommandObjectTarget.cpp lldb/source/Commands/CommandObjectThread.cpp lldb/source/Commands/CommandObjectType.cpp lldb/source/Commands/CommandObjectWatchpoint.cpp lldb/source/Core/FormatEntity.cpp lldb/source/Core/IOHandlerCursesGUI.cpp lldb/source/Core/ValueObject.cpp lldb/source/Core/ValueObjectConstResult.cpp lldb/source/Core/ValueObjectConstResultCast.cpp lldb/source/Core/ValueObjectConstResultChild.cpp lldb/source/Core/ValueObjectConstResultImpl.cpp lldb/source/Core/ValueObjectList.cpp lldb/source/Core/ValueObjectRegister.cpp lldb/source/Core/ValueObjectSyntheticFilter.cpp lldb/source/Core/ValueObjectUpdater.cpp lldb/source/DataFormatters/FormatManager.cpp lldb/source/DataFormatters/TypeSynthetic.cpp lldb/source/DataFormatters/ValueObjectPrinter.cpp lldb/source/DataFormatters/VectorType.cpp lldb/source/Expression/ExpressionVariable.cpp lldb/source/Target/StackFrame.cpp lldb/source/Target/Target.cpp lldb/source/Target/Thread.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/include/lldb/Core/ValueObject.h b/lldb/include/lldb/Core/ValueObject.h
index 0f1b8c98ae..cd80f8e428 100644
--- a/lldb/include/lldb/Core/ValueObject.h
+++ b/lldb/include/lldb/Core/ValueObject.h
@@ -468,7 +468,6 @@ public:
   virtual std::optional<lldb::ValueObjectSP>
   GetChildAtIndex(size_t idx, bool can_create = true);
 
-
   virtual lldb::ValueObjectSP GetChildMemberWithName(llvm::StringRef name,
                                                      bool can_create = true);
   /// The method always creates missing children in the path, if necessary.

``````````

</details>


https://github.com/llvm/llvm-project/pull/77375