[Lldb-commits] [lldb] [lldb][NFCI] Remove BreakpointIDList::InsertStringArray (PR #77161)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 8 10:48:25 PST 2024


bulbazord wrote:

> LGTM!
> 
> I see that we still have `FindAndReplaceIDRanges` referencing CommandReturnObject; out of curiosity, have you had a chance to look into removing that one (if it makes sense)? I see that `CommandReturnObject` is neither `#include`ed nor forward declared in the header, so the code is very much relying on others files to do either of those.

Yes, I planned on doing that in a follow-up. :)

https://github.com/llvm/llvm-project/pull/77161


More information about the lldb-commits mailing list