[Lldb-commits] [lldb] [lldb] Fix Intel PT plugin compile errors (PR #77252)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Sun Jan 7 21:34:41 PST 2024
================
@@ -103,12 +103,10 @@ TraceIntelPTBundleLoader::CreateEmptyProcess(lldb::pid_t pid,
ParsedProcess parsed_process;
parsed_process.target_sp = target_sp;
- // This should instead try to directly create an instance of ProcessTrace.
- // ProcessSP process_sp = target_sp->CreateProcess(
- // /*listener*/ nullptr, "trace",
- // /*crash_file*/ nullptr,
- // /*can_connect*/ false);
-
+ ProcessSP process_sp = target_sp->CreateProcess(
+ /*listener*/ nullptr, "trace",
+ /*crash_file*/ nullptr,
+ /*can_connect*/ false);
----------------
JDevlieghere wrote:
Should the original comment be kept as a FIXME?
https://github.com/llvm/llvm-project/pull/77252
More information about the lldb-commits
mailing list