[Lldb-commits] [llvm] [lldb] [DoNotMerge] DW_IDX_parent full implementation (PR #77121)

via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 5 09:25:51 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 2b88bd110cbe61e1e3ef764d0362a75dc7c9cd50 e3749d29f25c9d7986a78781ebbeaf1af682c1be -- lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h lldb/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.h lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.h lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp lldb/unittests/SymbolFile/DWARF/DWARFDIETest.cpp llvm/include/llvm/CodeGen/AccelTable.h llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp llvm/lib/DWARFLinker/DWARFLinker.cpp llvm/lib/DWARFLinkerParallel/DWARFLinkerImpl.cpp llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
index 775b7a2e73..340b9acf80 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
@@ -192,9 +192,8 @@ DWARFDebugInfo::GetDIE(const DIERef &die_ref) {
   return DWARFDIE(); // Not found
 }
 
-llvm::StringRef
-DWARFDebugInfo::PeekDIEName(const DIERef &die_ref) {
-  if(DWARFUnit *cu = GetUnit(die_ref))
+llvm::StringRef DWARFDebugInfo::PeekDIEName(const DIERef &die_ref) {
+  if (DWARFUnit *cu = GetUnit(die_ref))
     return cu->GetNonSkeletonUnit().PeekDIEName(die_ref.die_offset());
   return llvm::StringRef();
 }
diff --git a/llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp b/llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp
index c412d17c67..ca859bca3b 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp
@@ -603,7 +603,7 @@ void Dwarf5AccelTableWriter::emitEntry(
 }
 
 void Dwarf5AccelTableWriter::emitData() {
-  DenseMap<uint64_t, MCSymbol*> DIEOffsetToAccelEntryLabel;
+  DenseMap<uint64_t, MCSymbol *> DIEOffsetToAccelEntryLabel;
 
   for (auto Offset : IndexedOffsets)
     DIEOffsetToAccelEntryLabel[Offset] = Asm->createTempSymbol("symbol");
@@ -614,7 +614,7 @@ void Dwarf5AccelTableWriter::emitData() {
     for (auto *Hash : Bucket) {
       // Remember to emit the label for our offset.
       Asm->OutStreamer->emitLabel(Hash->Sym);
-      for (const auto *Value : Hash->getValues<DWARF5AccelTableData*>())
+      for (const auto *Value : Hash->getValues<DWARF5AccelTableData *>())
         emitEntry(*Value, DIEOffsetToAccelEntryLabel, EmittedAccelEntrySymbols);
       Asm->OutStreamer->AddComment("End of list: " + Hash->Name.getString());
       Asm->emitInt8(0);

``````````

</details>


https://github.com/llvm/llvm-project/pull/77121


More information about the lldb-commits mailing list