[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

[Greg Clayton via lldb-commits]

clayborg wrote:

I recently ran into this issue when looking at new failures in:

https://github.com/llvm/llvm-project/pull/74786#issuecomment-1874921872

And this was referred to in bug report:

https://github.com/llvm/llvm-project/issues/53904

After looking at the code, I believe we do need to parse contained types for a struct/class/union as we don't get an external AST source call for them. So I do believe this is the right thing to do. Even if we do parse the extra types, if we have a class within a class, then it will add a forward declaration to it only, and expand it later if any only if it is needed. I have attached a slightly different version of this patch to https://github.com/llvm/llvm-project/issues/53904 for reference.

https://github.com/llvm/llvm-project/pull/66879