[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 21 08:17:26 PST 2023


=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>,
=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>,
=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/76112 at github.com>


================
@@ -23,6 +23,16 @@
 
 namespace lldb_private {
 
+struct Information {
----------------
DavidSpickett wrote:

This should be within the Stream class.

Also the name is too generic, `HighlightSettings` maybe? Choosing a name is hard but something that says what the information is about.

https://github.com/llvm/llvm-project/pull/76112


More information about the lldb-commits mailing list