[Lldb-commits] [lldb] 7767c58 - [lldb][DWARF] Search for symbols in all external modules (#75927)

[via lldb-commits]

Author: David Spickett
Date: 2023-12-20T14:48:01Z
New Revision: 7767c5856d85cd1acf2efc32f77fdf07f00f9ff4

URL: https://github.com/llvm/llvm-project/commit/7767c5856d85cd1acf2efc32f77fdf07f00f9ff4
DIFF: https://github.com/llvm/llvm-project/commit/7767c5856d85cd1acf2efc32f77fdf07f00f9ff4.diff

LOG: [lldb][DWARF] Search for symbols in all external modules (#75927)

The way this code was updated in
dd9587795811ba21e6ca6ad52b4531e17e6babd6 meant that if the first module
did not have the symbol, the iteration stopped as returning true means
stop. So only if every module had the symbol would we find it, in the
last module.

Invert the condition to break when we find the first instance, which is
what the previous code did.

Added: 
    

Modified: 
    lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
index 334876620249fc..3e08f2550081f2 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -175,7 +175,7 @@ TypeSP DWARFASTParserClang::ParseTypeFromClangModule(const SymbolContext &sc,
         *sc.comp_unit, results.GetSearchedSymbolFiles(), [&](Module &module) {
           module.FindTypes(query, results);
           pcm_type_sp = results.GetTypeMap().FirstType();
-          return !pcm_type_sp;
+          return (bool)pcm_type_sp;
         });
   }