[Lldb-commits] [lldb] [lldb] Remove pre GCC 4.8 workaround (PR #73981)

Brad Smith via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 30 12:28:08 PST 2023


https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/73981

The minimum GCC version was bumped up from 4.8 to 5.1 and then even newer
awhile ago so garbage collect the pre 4.8 workaround.

https://reviews.llvm.org/D66188

>From a79e4d06f16e2460c7521874c13370022bbb5952 Mon Sep 17 00:00:00 2001
From: Brad Smith <brad at comstyle.com>
Date: Thu, 30 Nov 2023 15:20:27 -0500
Subject: [PATCH] [lldb] Remove pre GCC 4.8 workaround

The minimum GCC version was bumped up from 4.8 to 5.1 and then even newer
awhile ago so garbage collect the pre 4.8 workaround.

https://reviews.llvm.org/D66188
---
 lldb/source/Host/common/Host.cpp | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lldb/source/Host/common/Host.cpp b/lldb/source/Host/common/Host.cpp
index 49eac0b0fa7b0c6..8314d3581f6a47f 100644
--- a/lldb/source/Host/common/Host.cpp
+++ b/lldb/source/Host/common/Host.cpp
@@ -133,11 +133,7 @@ class ScopedPThreadCancelDisabler {
 #endif // __linux__
 
 #ifdef __linux__
-#if defined(__GNUC__) && (__GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ < 8))
-static __thread volatile sig_atomic_t g_usr1_called;
-#else
 static thread_local volatile sig_atomic_t g_usr1_called;
-#endif
 
 static void SigUsr1Handler(int) { g_usr1_called = 1; }
 #endif // __linux__



More information about the lldb-commits mailing list