[Lldb-commits] [lldb] Add option to pass thread ID to thread select command (PR #73596)

Felipe de Azevedo Piovezan via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 29 09:53:05 PST 2023


================
@@ -807,6 +808,23 @@ void CommandCompletions::TypeCategoryNames(CommandInterpreter &interpreter,
       });
 }
 
+void CommandCompletions::ThreadIDs(CommandInterpreter &interpreter,
+                                   CompletionRequest &request,
+                                   SearchFilter *searcher) {
+  const ExecutionContext &exe_ctx = interpreter.GetExecutionContext();
+  if (!exe_ctx.HasProcessScope())
+    return;
+
+  ThreadList &threads = exe_ctx.GetProcessPtr()->GetThreadList();
+  lldb::ThreadSP thread_sp;
+  for (uint32_t idx = 0; (thread_sp = threads.GetThreadAtIndex(idx)); ++idx) {
----------------
felipepiovezan wrote:

minor nit, don't block the review on this, but why do you have ()s here?

https://github.com/llvm/llvm-project/pull/73596


More information about the lldb-commits mailing list