[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

[David Spickett via lldb-commits]

=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/69422 at github.com>


================
@@ -1618,12 +1621,15 @@ static uint32_t LookupSymbolInModule(CommandInterpreter &interpreter,
         if (symbol->ValueIsAddress()) {
           DumpAddress(
               interpreter.GetExecutionContext().GetBestExecutionContextScope(),
-              symbol->GetAddressRef(), verbose, all_ranges, strm);
+              symbol->GetAddressRef(), verbose, all_ranges, strm,
+              use_color ? name : nullptr);
----------------
DavidSpickett wrote:

I think there might be a bug here. We have this `name_is_regex` and this is not checking it.

Should it be:
```
use_color && name_is_regex ? name : nullptr
```

So that when we have colours enabled, but do not search by regex, we do not get coloring.

First step to confirm would be to add a test that checks this and see if it fails.

https://github.com/llvm/llvm-project/pull/69422