[Lldb-commits] [lldb] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

Jordan Rupprecht via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 27 14:53:47 PST 2023


rupprecht wrote:

> * This is still early enough that the standard `unittest` framework will recognize the test as xfail/skip by the time the test actually runs.

I did a little bit more research, turns out this is not a difference between unittest and unittest2, but rather just something we have in our ancient, vendored copy of unittest2.

Our copy of `unittest2` originates from 2010 in 73258830f391047d9ee9ae4a07fd8ced4d7cf0a9, and has never undergone a version upgrade AFAICT. Two commits, both applied Mar 20, 2013, implement some features for `subTest` in both `unittest` and `unittest2` for https://bugs.python.org/issue16997:
- https://github.com/python/cpython/commit/c9b3ef2df06818f055e555c1d23e3ff2d5bf2d74
- https://hg.python.org/unittest2/rev/0daffa9ee7c1

The important part of that diff is it stops raising `_ExpectedFailure` and starts just setting `__unittest_expecting_failure__` on the test method. The full discussion on that is https://bugs.python.org/issue16997, especially starting around [msg183450](https://bugs.python.org/issue16997#msg183450)

https://github.com/llvm/llvm-project/pull/73067


More information about the lldb-commits mailing list