[Lldb-commits] [lldb] [lldb] correct inconsistent order of messages on process launch (PR #73173)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 23 00:41:29 PST 2023


================
@@ -265,8 +265,6 @@ class CommandObjectProcessLaunch : public CommandObjectProcessLaunchOrAttach {
         process_sp->SyncIOHandler(0, std::chrono::seconds(2));
 
         llvm::StringRef data = stream.GetString();
----------------
DavidSpickett wrote:

If we don't need `data` you could move it down to where it's used.

I'd say do `if (llvm::StringRef data = stream.GetString())...` but I don't think that will work because Stringref doesn't have `operator bool`.

https://github.com/llvm/llvm-project/pull/73173


More information about the lldb-commits mailing list