[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)
via lldb-commits
lldb-commits at lists.llvm.org
Mon Nov 20 01:01:08 PST 2023
=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>,taalhaataahir0102
<23100293 at lums.edu.pk>,
=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>,
=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>,taalhaataahir0102
<23100293 at lums.edu.pk>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/69422 at github.com>
taalhaataahir0102 wrote:
Hi David! We're new to git that why there are some stupid things are done by me in the above commit. 😞 Sorry for that.
Now trying to to do this in a new branch:
> Then take the opportunity to squash your commits and rebase them onto the latest main branch. You will do fixup commits on top of this when other reviewers request changes, then the final set of commits will be squashed and the PR title/message is used as the commit message.
Once done successfully there, I'll update this branch and we'll inform you + change the status from draft to PR for other reviewers.
1 thing which we are not able to get: If we squash our commits into a single commit and add 2 authors for that commit (Jose and Talha), like done in this one: https://github.com/llvm/llvm-project/pull/69422/commits/4a47c6a9185ce157e40f79a7adf9ca0b95af7c22
Than the part of code updated by any of us will be by the name of both of us right?
e.g.,
int a = 10 // commit by Talha
int b = 20; // commit by Jose
But after squash and co-author:
int a = 10 // commit by Talha and Jose
int b = 20; // commit by Talha and Jose
This is what going to happen right? But than how we will be able to see which changes are made by the individuals? 🤔 And whats the purpose of squashing 🤔
https://github.com/llvm/llvm-project/pull/69422
More information about the lldb-commits
mailing list