[Lldb-commits] [lldb] 70900ec - [lldb][DWARFASTParserClang][NFC] Clarify comment around static member variable handling (#72495)

[via lldb-commits]

Author: Michael Buch
Date: 2023-11-16T16:09:47Z
New Revision: 70900ec79984105c661a923aae2f993394ae7aae

URL: https://github.com/llvm/llvm-project/commit/70900ec79984105c661a923aae2f993394ae7aae
DIFF: https://github.com/llvm/llvm-project/commit/70900ec79984105c661a923aae2f993394ae7aae.diff

LOG: [lldb][DWARFASTParserClang][NFC] Clarify comment around static member variable handling (#72495)

Added: 
    

Modified: 
    lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
index 37efe70461977ad..abe3c673e2cce69 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -2963,9 +2963,9 @@ void DWARFASTParserClang::ParseSingleMember(
   // whereas GCC emits it only for static data members if not part of an
   // anonymous namespace. The flag that is consistently emitted for static
   // data members is DW_AT_declaration, so we check it instead.
-  // FIXME: Since DWARFv5, static data members are marked DW_AT_variable so we
+  // The following block is only necessary to support DWARFv4 and earlier.
+  // Starting with DWARFv5, static data members are marked DW_AT_variable so we
   // can consistently detect them on both GCC and Clang without below heuristic.
-  // Remove this block if we ever drop DWARFv4 support.
   if (attrs.member_byte_offset == UINT32_MAX &&
       attrs.data_bit_offset == UINT64_MAX && attrs.is_declaration) {
     CreateStaticMemberVariable(die, attrs, class_clang_type);