[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

Jordan Rupprecht via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 15 17:37:14 PST 2023


rupprecht wrote:

> Beautiful, thank you for working on this. After this change, what's left to get us using the python-provided `unittest`?

The giant lambda inside `_decorateTest` has one remaining `self` reference, which is `self.getDebugInfo()` -- i.e. the debug info specific variant created by the metaclass factory. My current approach is basically to annotate the test in a similar way as we do for the `@no_debug_info_test`, with some state that indicates which debug info kinds should be skipped/xfailed, and then when the metaclass creates each variant, it can create them as being wrapped w/ `@skip` or `@expectedFailure` depending on the result of that.

After that, not a lot. Both @JDevlieghere and I have made an attempt at this in the past, and so we've already done a lot of cleanup to make things work with either library.

https://github.com/llvm/llvm-project/pull/72416


More information about the lldb-commits mailing list