[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 15 14:30:06 PST 2023


jasonmolenda wrote:

> LGTM with a few nits. I like "constituents".
> 
> This is a pretty big patch which makes reviewing it challenging. I know it's a big change that touches a lot of things but I'm sure that this could've been broken up into smaller patches if you keep that goal in mind from the beginning. Something to look out for in the future.

Thanks for the feedback.  Yeah originally this patch was a bit smaller but it has Grown as I've addressed (correct, good) feedback from everyone and now it's a little bit of a monster.  I'm surely going to have to rebase it before I can merge.

https://github.com/llvm/llvm-project/pull/68845


More information about the lldb-commits mailing list