[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

[David Spickett via lldb-commits]

=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/69422 at github.com>


DavidSpickett wrote:

Guess I'm gonna take the 100th comment here :)

This is almost ready for "proper" review (people that aren't me). So first thing is to address the few minor comments I have from this latest review round.

Then, since there's so much discussion here already, you need to make it very clear that this is ready for review. So update the PR title and description with what you wish to be shown when the change is landed.

The title of the first commit `[lldb] ....` is fine (and thank you for including the tag!), just paste that into the PR title. For the body, describe how you've implemented the change and, if you can find it, note the feature request issue that originally started all this (if that's been lost it's fine, this is a good feature regardless).

The description should also make it clear who worked on the patch. Given that @taalhaataahir0102 opened the PR, it will be landed with their address (unless changed), so you should add a co-author tag so that everyone gets the proper credit. This also goes into the PR description.

See https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors.

Then take the opportunity to squash your commits and rebase them onto the latest main branch. You will do fixup commits on top of this when other reviewers request changes, then the final set of commits will be squashed and the PR title/message is used as the commit message.

Once you've done that, take the PR out of draft mode and as soon as I see that's done I'll add a comment with some context for reviewers and make sure it gets the right labeling and such.

(I did consider making you open a new PR, but it is useful for reviewers to see what we have already discussed so let's just stay with this one, if people complain you can make a new one and blame me :) )

Thank you for sticking with this for as long as you have. Other reviewers will have more comments I'm sure, so don't get disheartened by that, you've already achieved a lot to get to this point.

https://github.com/llvm/llvm-project/pull/69422