[Lldb-commits] [lldb] [lldb-dap] Fixing a type encoding issue with dap Stopped events. (PR #72292)

[Greg Clayton via lldb-commits]

================
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread &thread,
     } else {
       body.try_emplace("reason", "breakpoint");
       char desc_str[64];
-      uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
-      uint64_t bp_loc_id = thread.GetStopReasonDataAtIndex(1);
-      snprintf(desc_str, sizeof(desc_str), "breakpoint %" PRIu64 ".%" PRIu64,
+      break_id_t bp_id = thread.GetStopReasonDataAtIndex(0);
----------------
clayborg wrote:

We have an abstract API to access stop reason data via `uint64_t SBThread::GetStopReasonDataAtIndex(...)` which returns a `uint64_t`, but the `break_id_t` is defined as `typedef int32_t break_id_t;`. If we want to show the breakpoint ID correctly as a negative number for internal breakpoints, then this should be ok.

https://github.com/llvm/llvm-project/pull/72292