[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

[José Lira Junior via lldb-commits]

junior-jl wrote:

>> 
    - Please remove any commented out code, comments that are now obvious from reading the code, etc.
    - Rename name to pattern, it will be a 1000% less confusing for all of us :)
    - Make sure that ninja check-lldb has no failures.
    - clang-format your changes (https://clang.llvm.org/docs/ClangFormat.html)
 
Hello again, David. We've done these. When I fetched the most recent changes in LLVM project today, the `ninja check-lldb` was okay again. Just FYI, I did not update any dependency.

```
$ ninja check-lldb
[259/260] Running lldb lit test suite
llvm-lit: /home/jose/lldb/llvm-project/llvm/utils/lit/lit/llvm/config.py:488: note: using clang: /home/jose/lldb/llvm-project/bin/clang

Testing Time: 208.89s

Total Discovered Tests: 2849
  Skipped          :    1 (0.04%)
  Unsupported      : 1327 (46.58%)
  Passed           : 1520 (53.35%)
  Expectedly Failed:    1 (0.04%)
```

I tried commenting on the more recent suggestions you made that were addressed.

Also, we have a few questions:

1. Should we add some tests to the file with `settings set use-color false`?
2. Right now, the colorize only works for symbols, i.e., the `-s` flag. Should this also work for the `-F` and `-n` flags? If so, is it better that we add this on this PR or in another patch?

Thanks in advance!

https://github.com/llvm/llvm-project/pull/69422