[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)
Med Ismail Bennani via lldb-commits
lldb-commits at lists.llvm.org
Sat Nov 4 20:07:59 PDT 2023
================
@@ -663,6 +663,18 @@ bool PythonDictionary::Check(PyObject *py_obj) {
return PyDict_Check(py_obj);
}
+bool PythonDictionary::HasKey(const llvm::Twine &key) const {
----------------
medismailben wrote:
`PythonDictionary::GetItem` have an overload that takes a `const llvm::Twine&` for the `key` parameter, so I wanted to stay consistent with the rest of the class. Also, I feel like `llvm::Twine` are offer more flexibility than `llvm::StringRef` and they offer an implicit constructor that takes a `llvm::StringRef`, so why not use it ?
https://github.com/llvm/llvm-project/pull/71260
More information about the lldb-commits
mailing list