[Lldb-commits] [lldb] [lldb] Change Breakpoint::AddName return value (PR #71236)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Alex Langford (bulbazord)

<details>
<summary>Changes</summary>

The return value is completely unused. Let's just return nothing.

---
Full diff: https://github.com/llvm/llvm-project/pull/71236.diff


2 Files Affected:

- (modified) lldb/include/lldb/Breakpoint/Breakpoint.h (+1-1) 
- (modified) lldb/source/Breakpoint/Breakpoint.cpp (+1-2) 


``````````diff
diff --git a/lldb/include/lldb/Breakpoint/Breakpoint.h b/lldb/include/lldb/Breakpoint/Breakpoint.h
index f2380157f111dd6..1daaee6c043fc56 100644
--- a/lldb/include/lldb/Breakpoint/Breakpoint.h
+++ b/lldb/include/lldb/Breakpoint/Breakpoint.h
@@ -525,7 +525,7 @@ class Breakpoint : public std::enable_shared_from_this<Breakpoint>,
 
 private: // The target needs to manage adding & removing names.  It will do the
          // checking for name validity as well.
-  bool AddName(llvm::StringRef new_name);
+  void AddName(llvm::StringRef new_name);
 
   void RemoveName(const char *name_to_remove) {
     if (name_to_remove)
diff --git a/lldb/source/Breakpoint/Breakpoint.cpp b/lldb/source/Breakpoint/Breakpoint.cpp
index ff4f195ea30909e..a94498a23a0fb27 100644
--- a/lldb/source/Breakpoint/Breakpoint.cpp
+++ b/lldb/source/Breakpoint/Breakpoint.cpp
@@ -841,9 +841,8 @@ bool Breakpoint::HasResolvedLocations() const {
 
 size_t Breakpoint::GetNumLocations() const { return m_locations.GetSize(); }
 
-bool Breakpoint::AddName(llvm::StringRef new_name) {
+void Breakpoint::AddName(llvm::StringRef new_name) {
   m_name_list.insert(new_name.str());
-  return true;
 }
 
 void Breakpoint::GetDescription(Stream *s, lldb::DescriptionLevel level,

``````````

</details>


https://github.com/llvm/llvm-project/pull/71236