[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

> Are you asking me to create a SymbolServer class for _this_ change, or do you want me to get this diff polished & landed, then create the abstraction before adding anything more? (Either is fine: I just can't quite tell what you're looking for right now)

I was suggesting the latter. 

As I was thinking about this a bit more and found some spare time, I gave the plugin conversion a try. I've created a PR (https://github.com/llvm/llvm-project/pull/71151) with the initial scaffolding and `LocateExecutableObjectFile` moved  into the plugin. Once that's complete, everything you're adding should fit perfectly in a new Debuginfod SymbolLocator plugin:

- The call to `llvm::HTTPClient::initialize()` can be done in the plugin instantiation.
- Plugins can have their own settings so we can set the URLs there. 
- Because of the way plugins work, they are tried in the order defined in the CMakeLists.txt, so if you make sure the `debuginfod` comes last, it'll be the fallback automatically. 

https://github.com/llvm/llvm-project/pull/70996