[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 2 08:46:09 PDT 2023


================
@@ -247,7 +247,17 @@ class Address {
   bool Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style,
             DumpStyle fallback_style = DumpStyleInvalid,
             uint32_t addr_byte_size = UINT32_MAX,
-            bool all_ranges = false) const;
+            bool all_ranges = false,
+            std::vector<std::pair<bool, const char*>>* info = nullptr) const;
----------------
DavidSpickett wrote:

Another way to put this is:
* When `name` is nullptr, we won't print any colours.
* When `use_colour` is false, we won't print any colours.

So why not use `name == nullptr` to also mean that colour is disabled?

https://github.com/llvm/llvm-project/pull/69422


More information about the lldb-commits mailing list