[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 7d77bbef4ad9230f6f427649373fe46a668aa909 5a37a703cd7c44bf9ecdfdfb77491ce9a18a4a72 -- lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h lldb/test/API/lang/cpp/const_static_integral_member/main.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
index e1486ced5bee..7fdc414f3313 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -139,7 +139,7 @@ static lldb::ModuleSP GetContainingClangModule(const DWARFDIE &die) {
 
 std::optional<DWARFFormValue>
 DWARFASTParserClang::FindConstantOnVariableDefinition(DWARFDIE die) {
-  assert (die.Tag() == llvm::dwarf::DW_TAG_member);
+  assert(die.Tag() == llvm::dwarf::DW_TAG_member);
 
   auto *dwarf = die.GetDWARF();
   if (!dwarf)
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
index 01b60bc8ac39..893a0315c852 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
@@ -375,12 +375,13 @@ private:
                        lldb_private::ClangASTImporter::LayoutInfo &layout_info);
 
   /// Tries to find the definition DW_TAG_variable DIE of the the specified
-  /// DW_TAG_member 'die'. If such definition exists, returns the DW_AT_const_value
-  /// of that definition if available. Returns std::nullopt otherwise.
+  /// DW_TAG_member 'die'. If such definition exists, returns the
+  /// DW_AT_const_value of that definition if available. Returns std::nullopt
+  /// otherwise.
   ///
   /// In newer versions of clang, DW_AT_const_value's are not attached to the
-  /// declaration of a inline static data-member anymore, but rather on its definition.
-  /// This function is used to locate said constant.
+  /// declaration of a inline static data-member anymore, but rather on its
+  /// definition. This function is used to locate said constant.
   std::optional<lldb_private::plugin::dwarf::DWARFFormValue>
   FindConstantOnVariableDefinition(lldb_private::plugin::dwarf::DWARFDIE die);
 };

``````````

</details>


https://github.com/llvm/llvm-project/pull/71004