[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 31 13:57:48 PDT 2023


================
@@ -614,6 +614,8 @@ class Process : public std::enable_shared_from_this<Process>,
     return error;
   }
 
+  virtual void DidLoadCore() {}
----------------
medismailben wrote:

I agree with @clayborg: attaching to a process and loading a core file are mutually exclusive actions so I can use re-using `DidAttach` in core file process plugins. However, if we rename `DidAttach` to `DidAttachOrLoadCore` then that would be called for non-corefile process plugins and I think that would be confusing to that a "LoadCore" mention in the context of the regular process.

@JDevlieghere if you think that using `DidAttach` in the core file process plugin context is confusing, I'm fine going back to my original implementation using `DidLoadCore`.

https://github.com/llvm/llvm-project/pull/70351


More information about the lldb-commits mailing list