[Lldb-commits] [libcxx] [openmp] [flang] [clang] [lldb] [compiler-rt] [llvm] [clang-tools-extra] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

[Giorgis Georgakoudis via lldb-commits]

================
@@ -274,7 +317,7 @@ struct RecordReplayTy {
   void saveKernelOutputInfo(const char *Name) {
     SmallString<128> OutputFilename = {
         Name, (isRecording() ? ".original.output" : ".replay.output")};
-    dumpDeviceMemory(OutputFilename);
+    dumpDeviceMemory(OutputFilename, /*saveDiff*/ true);
----------------
ggeorgakoudis wrote:

If `saveDiff` is always `true` when replaying then this is incompatible with verification in the `llvm-omp-kernel-replay` tool, right? We should set `saveDiff` either through an env var or through the `llvm-omp-kernel-replay` tool (latter is better) and make the `llvm-omp-kernel-replay` tool aware. If `saveDiff` is true then the tool should just show the differences already saved in the diff files.

https://github.com/llvm/llvm-project/pull/70667