[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 31 12:51:42 PDT 2023


================
@@ -614,6 +614,8 @@ class Process : public std::enable_shared_from_this<Process>,
     return error;
   }
 
+  virtual void DidLoadCore() {}
----------------
JDevlieghere wrote:

Would it be worth to rename that function to `DidAttachOrLoadCore` (or just `DidAttachOrLoad`) to make it obvious that it handles both cases? I'm all for reusing `DidAttach` but it does seem a bit weird for a core file process.

https://github.com/llvm/llvm-project/pull/70351


More information about the lldb-commits mailing list