[Lldb-commits] [lldb] [lldb] Fix missing comsumeError() with LLDB_LOG in ObjectFileCOFF/PECOFF (PR #70793)

via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 31 05:30:54 PDT 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff c280bed85a8b9cd6ebf48f9f2923890edc7039f0 5091d1ffec05ec65e4e762d2bea8735d0de7b6fb -- lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp llvm/include/llvm-c/Orc.h llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h llvm/include/llvm/ExecutionEngine/JITLink/aarch32.h llvm/include/llvm/ExecutionEngine/JITLink/aarch64.h llvm/include/llvm/ExecutionEngine/JITLink/loongarch.h llvm/lib/ExecutionEngine/JITLink/ELF_aarch32.cpp llvm/lib/ExecutionEngine/JITLink/aarch32.cpp llvm/tools/llvm-jitlink/llvm-jitlink-elf.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/ExecutionEngine/JITLink/aarch32.cpp b/llvm/lib/ExecutionEngine/JITLink/aarch32.cpp
index b31dd5c22..674220025 100644
--- a/llvm/lib/ExecutionEngine/JITLink/aarch32.cpp
+++ b/llvm/lib/ExecutionEngine/JITLink/aarch32.cpp
@@ -627,7 +627,7 @@ static Symbol &createAnonymousPointer(LinkGraph &G, Section &PointerSection,
   constexpr uint8_t AlignmentThumb = 2;
   constexpr orc::ExecutorAddr MaxAddrThumb{~uint32_t(AlignmentThumb - 1)};
   constexpr uint64_t PointerSize = 4;
-  constexpr char NullPointerContent[] { 0x00, 0x00, 0x00, 0x00 };
+  constexpr char NullPointerContent[]{0x00, 0x00, 0x00, 0x00};
   auto &B = G.createContentBlock(PointerSection, NullPointerContent,
                                  MaxAddrThumb, AlignmentThumb, 0);
   if (InitialTarget)
diff --git a/llvm/tools/llvm-jitlink/llvm-jitlink-elf.cpp b/llvm/tools/llvm-jitlink/llvm-jitlink-elf.cpp
index 2adf6df9b..4b7b3f9be 100644
--- a/llvm/tools/llvm-jitlink/llvm-jitlink-elf.cpp
+++ b/llvm/tools/llvm-jitlink/llvm-jitlink-elf.cpp
@@ -56,9 +56,9 @@ static Expected<Symbol &> getELFStubTarget(LinkGraph &G, Block &B) {
     return E.takeError();
   auto &GOTSym = E->getTarget();
   if (!GOTSym.isDefined())
-    return make_error<StringError>(
-        "Stubs entry in " + G.getName() + " does not point to GOT entry",
-        inconvertibleErrorCode());
+    return make_error<StringError>("Stubs entry in " + G.getName() +
+                                       " does not point to GOT entry",
+                                   inconvertibleErrorCode());
   if (!isELFGOTSection(GOTSym.getBlock().getSection()))
     return make_error<StringError>(
         "Stubs entry in " + G.getName() + ", \"" +

``````````

</details>


https://github.com/llvm/llvm-project/pull/70793


More information about the lldb-commits mailing list