[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 30 05:06:13 PDT 2023


DavidSpickett wrote:

> Can you please confirm if passing the pointer to CommandInterpreter object in PrintRed function to get the use-color options a good idea?

Yes but it can be better :) See my comments.

> Are the test cases good enough and also does the future plan sounds Okay?

I suggested one more test case, otherwise they look good to me.

https://github.com/llvm/llvm-project/pull/69422


More information about the lldb-commits mailing list