[Lldb-commits] [lldb] b82c629 - Fix log format strings

Adrian Prantl via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 25 16:42:48 PDT 2023


Author: Adrian Prantl
Date: 2023-10-25T16:42:37-07:00
New Revision: b82c62978690a8a518f22780bd13ac2b5ddcd2b8

URL: https://github.com/llvm/llvm-project/commit/b82c62978690a8a518f22780bd13ac2b5ddcd2b8
DIFF: https://github.com/llvm/llvm-project/commit/b82c62978690a8a518f22780bd13ac2b5ddcd2b8.diff

LOG: Fix log format strings

Added: 
    

Modified: 
    lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm

Removed: 
    


################################################################################
diff  --git a/lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm b/lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm
index 1af450374e776b1..e3506a01c606b78 100644
--- a/lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm
+++ b/lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm
@@ -394,7 +394,7 @@ static void ParseOSVersion(llvm::VersionTuple &version, NSString *Key) {
   if (log) {
     std::string cmdstr;
     args.GetCommandString(cmdstr);
-    log->Printf("GetXcodeSDK() running shell cmd '%s'", cmdstr.c_str());
+    LLDB_LOG(log, "GetXcodeSDK() running shell cmd '{0}'", cmdstr);
   }
 
   int status = 0;
@@ -410,13 +410,13 @@ static void ParseOSVersion(llvm::VersionTuple &version, NSString *Key) {
   // Check that xcrun returned something useful.
   if (error.Fail()) {
     // Catastrophic error.
-    LLDB_LOG(log, "xcrun failed to execute: %s", error.AsCString());
+    LLDB_LOG(log, "xcrun failed to execute: {0}", error);
     return error.ToError();
   }
   if (status != 0) {
     // xcrun didn't find a matching SDK. Not an error, we'll try
     // 
diff erent spellings.
-    LLDB_LOG(log, "xcrun returned exit code %d", status);
+    LLDB_LOG(log, "xcrun returned exit code {0}", status);
     return "";
   }
   if (output_str.empty()) {


        


More information about the lldb-commits mailing list