[Lldb-commits] [lldb] [LLDB][NFC] Remove DWARFASTParserClang as friend from SymbolFileDWARF (PR #70157)

[Greg Clayton via lldb-commits]

================
@@ -325,15 +323,46 @@ class SymbolFileDWARF : public SymbolFileCommon {
     m_file_index = file_index;
   }
 
-protected:
   typedef llvm::DenseMap<const DWARFDebugInfoEntry *, Type *> DIEToTypePtr;
-  typedef llvm::DenseMap<const DWARFDebugInfoEntry *, lldb::VariableSP>
-      DIEToVariableSP;
+
+  virtual DIEToTypePtr &GetDIEToType() { return m_die_to_type; }
+
   typedef llvm::DenseMap<const DWARFDebugInfoEntry *,
                          lldb::opaque_compiler_type_t>
       DIEToClangType;
+
+  virtual DIEToClangType &GetForwardDeclDieToClangType() {
----------------
clayborg wrote:

`DIEToClangType` could be renamed to `DieToCompilerType`
`ClangTypeToDIE` could be renamed to `ComilerTypeToDIE`
Anything that is a map of something to `lldb::opaque_compiler_type_t`, or `lldb::opaque_compiler_type_t` to something can be renamed to be "CompilerType" instead of "ClangType"

https://github.com/llvm/llvm-project/pull/70157