[Lldb-commits] [lldb] [lldb/Interpreter] Make ScriptedInterface Object creation more generic (PR #68052)

[Med Ismail Bennani via lldb-commits]

================
@@ -19,11 +19,11 @@
 namespace lldb_private {
 class ScriptedPlatformInterface : virtual public ScriptedInterface {
 public:
-  StructuredData::GenericSP
+  virtual llvm::Expected<StructuredData::GenericSP>
   CreatePluginObject(llvm::StringRef class_name, ExecutionContext &exe_ctx,
                      StructuredData::DictionarySP args_sp,
-                     StructuredData::Generic *script_obj = nullptr) override {
-    return {};
+                     StructuredData::Generic *script_obj = nullptr) {
+    llvm_unreachable("unimplemented!");
----------------
medismailben wrote:

This can't be virtual pure because the `ScriptInterpreter` base class implements `virtual lldb::Scripted{Process,Platform,Thread}Interface()` methods that instantiate each base interface.

https://github.com/llvm/llvm-project/pull/68052