[Lldb-commits] [lldb] [lldb] Part 1 of 2 - Refactor `CommandObject::Execute(...)` return `void` (not `bool`) (PR #69989)

Pete Lawrence via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 24 13:00:58 PDT 2023


================
@@ -715,7 +715,7 @@ Thread *CommandObject::GetDefaultThread() {
     return nullptr;
 }
 
-bool CommandObjectParsed::Execute(const char *args_string,
+void CommandObjectParsed::Execute(const char *args_string,
                                   CommandReturnObject &result) {
   bool handled = false;
----------------
PortalPete wrote:

I looked into removing `handled` but if we did so, then we'd have to add a bit more conditional logic to cover when `HasOverrideCallback()` or `HasOverrideCallback()` return `false`/`NULL`;

https://github.com/llvm/llvm-project/pull/69989


More information about the lldb-commits mailing list