[Lldb-commits] [lldb] [lldb] Part 2 of 2 - Refactor `CommandObject::DoExecute(...)` return `void` (not `bool`) (PR #69991)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 24 10:57:03 PDT 2023


================
@@ -34,16 +34,17 @@ CommandObjectMultipleThreads::CommandObjectMultipleThreads(
   m_arguments.push_back({thread_arg});
 }
 
-bool CommandObjectIterateOverThreads::DoExecute(Args &command,
+void CommandObjectIterateOverThreads::DoExecute(Args &command,
                                                 CommandReturnObject &result) {
   result.SetStatus(m_success_return);
 
   bool all_threads = false;
   if (command.GetArgumentCount() == 0) {
     Thread *thread = m_exe_ctx.GetThreadPtr();
-    if (!thread || !HandleOneThread(thread->GetID(), result))
-      return false;
-    return result.Succeeded();
+    if (thread) {
+      HandleOneThread(thread->GetID(), result);
+    }
----------------
bulbazord wrote:

LLVM style guidelines say no braces for single-line block in if/else/loop constructs

https://github.com/llvm/llvm-project/pull/69991


More information about the lldb-commits mailing list