[Lldb-commits] [lldb] [lldb][gardening] Remove full name of "DWARFDIE" type in GetTypeForDIE (PR #70062)

Augusto Noronha via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 24 09:47:44 PDT 2023


https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/70062

When moving the GetTypeForDIE function from DWARFASTParserClang to DWARFASTParser, I kept the signature as-is. To match the rest of the function signatures in DWARFASTParser, remove the full name (lldb_private::plugin::dwarf::DWARFDIE -> DWARFDIE) in the signature of DWARFASTParser::GetTypeForDIE.

>From 3c6b7d07b088c50bb4efc05c9ffac484fd6d30a6 Mon Sep 17 00:00:00 2001
From: Augusto Noronha <augusto2112 at me.com>
Date: Tue, 24 Oct 2023 09:44:19 -0700
Subject: [PATCH] [lldb][gardening] Remove full name of "DWARFDIE" type in
 GetTypeForDIE

When moving the GetTypeForDIE function from DWARFASTParserClang to
DWARFASTParser, I kept the signature as-is. To match the rest of the
function signatures in DWARFASTParser, remove the full name
(lldb_private::plugin::dwarf::DWARFDIE -> DWARFDIE) in the signature
of DWARFASTParser::GetTypeForDIE.
---
 lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h
index 6749cb0e5db17a6..66db396279e0630 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h
@@ -64,8 +64,7 @@ class DWARFASTParser {
   ParseChildArrayInfo(const DWARFDIE &parent_die,
                       const ExecutionContext *exe_ctx = nullptr);
 
-  lldb_private::Type *
-  GetTypeForDIE(const lldb_private::plugin::dwarf::DWARFDIE &die);
+  lldb_private::Type *GetTypeForDIE(const DWARFDIE &die);
 
   static lldb::AccessType GetAccessTypeFromDWARF(uint32_t dwarf_accessibility);
 



More information about the lldb-commits mailing list