[Lldb-commits] [lldb] [lldb] Part 2 of 2 - Refactor `CommandObject::DoExecute(...)` return `void` (not `bool`) (PR #69991)

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 23 23:37:31 PDT 2023


================
@@ -429,11 +428,12 @@ llvm::StringRef CommandObjectProxy::GetUnsupportedError() {
   return "command is not implemented";
 }
 
-bool CommandObjectProxy::Execute(const char *args_string,
+void CommandObjectProxy::Execute(const char *args_string,
                                  CommandReturnObject &result) {
   CommandObject *proxy_command = GetProxyCommandObject();
-  if (proxy_command)
-    return proxy_command->Execute(args_string, result);
+  if (proxy_command) {
+    proxy_command->Execute(args_string, result);
----------------
jasonmolenda wrote:

I think you meant to put a `return` in this block, so we don't append an UnsupportedError before returning.

https://github.com/llvm/llvm-project/pull/69991


More information about the lldb-commits mailing list