[Lldb-commits] [lldb] Reintroduce accidentally deleted "protected" keyword in SymbolFileDWARF (PR #69990)

Augusto Noronha via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 23 18:26:59 PDT 2023


================
@@ -321,6 +322,7 @@ class SymbolFileDWARF : public SymbolFileCommon {
     m_file_index = file_index;
   }
 
+protected:
----------------
augusto2112 wrote:

I think the big issue on keeping everything public is that will will use those methods without realizing they were supposed to be private (like I did), and then it'll be a bigger problem to disentangle that later on.

https://github.com/llvm/llvm-project/pull/69990


More information about the lldb-commits mailing list