[Lldb-commits] [lldb] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 23 10:22:30 PDT 2023


jimingham wrote:

SymbolFiles can be owned by more than one debugger at a time.  That's actually a very common mode for GUI's that can host more than one debugging session at a time.  You can iterate over the list of debuggers from anywhere, and query the value of this property, but if two Debugger's disagree about the value, you won't have a way to figure out which one should win.

Jim


> On Oct 20, 2023, at 2:35 PM, Tom Yang ***@***.***> wrote:
> 
> 
> Because SymbolFile is holding onto the function pointer as a static member, this is a global setting that you can't apply to only just one SBDebugger object. It's an all-or-nothing thing. Maybe that's what you want, but LLDB already has architectural issues with certain functionality being difficult to detangle from global state (e.g. Logging). Maybe we could make it a property of the Debugger instead?
> 
> That sounds good to me, though I didn't think there was a path to the debugger from SymbolFileDWARF?
> 
>> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/69517#issuecomment-1773422913>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW7QU4NNYPNWKRGANJLYALVBHAVCNFSM6AAAAAA6GECPBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGQZDEOJRGM>.
> You are receiving this because you are on a team that was mentioned.
> 



https://github.com/llvm/llvm-project/pull/69517


More information about the lldb-commits mailing list