[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 23 07:28:00 PDT 2023


================
@@ -1548,14 +1581,17 @@ static uint32_t LookupSymbolInModule(CommandInterpreter &interpreter,
       Symbol *symbol = symtab->SymbolAtIndex(match_indexes[i]);
       if (symbol) {
         if (symbol->ValueIsAddress()) {
+          // Using the new dump function to add colors in the summary.
----------------
DavidSpickett wrote:

If these are for your own info when developing, cool. It's a nice habit to get into, but later we'll go through and remove all these that are "obvious" in production code.

One thing I do is `// TODO: ...`. Then before I push for review I can do `git show | grep TODO` and see if I forgot anything.

https://github.com/llvm/llvm-project/pull/69422


More information about the lldb-commits mailing list