[Lldb-commits] [lldb] [lldb][test] Turn ObjC string literals to C-style literals (NFC) (PR #69793)

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 20 16:17:05 PDT 2023


https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/69793

The underlying timezone classes are being reimplemented in Swift, and these strings will
be Swift strings, without the ObjC `@` prefix. Leaving off the `@` makes these tests
usable both before and after the reimplmentation of Foundation in Swift.


>From adc191f11ab07466f22bbb8a8d45abb9e417913b Mon Sep 17 00:00:00 2001
From: Dave Lee <davelee.com at gmail.com>
Date: Thu, 20 Jul 2023 19:29:29 -0700
Subject: [PATCH] [lldb][test] Turn ObjC string literals to C-style literals
 (NFC)

The underlying timezone classes are being reimplemented in Swift, and these strings will
be Swift strings, without the ObjC `@` prefix. Leaving off the `@` makes these tests
usable both before and after the reimplmentation of Foundation in Swift.
---
 .../data-formatter-objc/TestDataFormatterObjCNSDate.py        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
index c4aec10505910ae..a1ffe84ad556f0e 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
@@ -53,12 +53,12 @@ def nsdate_data_formatter_commands(self):
 
         self.expect(
             "frame variable cupertino home europe",
-            substrs=['@"America/Los_Angeles"', '@"Europe/Rome"', '@"Europe/Paris"'],
+            substrs=['"America/Los_Angeles"', '"Europe/Rome"', '"Europe/Paris"'],
         )
 
         self.expect(
             "frame variable cupertino_ns home_ns europe_ns",
-            substrs=['@"America/Los_Angeles"', '@"Europe/Rome"', '@"Europe/Paris"'],
+            substrs=['"America/Los_Angeles"', '"Europe/Rome"', '"Europe/Paris"'],
         )
 
         self.expect(



More information about the lldb-commits mailing list