[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 19 01:14:57 PDT 2023


================
@@ -135,5 +135,5 @@ def test_watch_address_with_invalid_watch_size(self):
             self.expect(
                 error.GetCString(),
                 exe=False,
-                substrs=["watch size of %d is not supported" % 365],
+                substrs=["Setting one of the watchpoint resources failed"],
----------------
DavidSpickett wrote:

Yeah I don't think it would need to be super specific, that is what logs are for. Drawing the distinction between failed because the stub didn't have resources, and failed because the stub exploded, that's more what I'd like to see.

And here the original error message is actually still pretty vague. It tells me that size N isn't support, but not what is supported (which is a whole other thing).

https://github.com/llvm/llvm-project/pull/68845


More information about the lldb-commits mailing list